fix: set network plugin to azure in agic addon#8429
Open
akshaysngupta wants to merge 2 commits intoAzure:mainfrom
Open
fix: set network plugin to azure in agic addon#8429akshaysngupta wants to merge 2 commits intoAzure:mainfrom
akshaysngupta wants to merge 2 commits intoAzure:mainfrom
Conversation
akshaysngupta
requested review from
FumingZhang and
andyliuliming
as code owners
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @akshaysngupta, |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
bot
requested review from
jsntcy,
kairu-ms,
necusjz and
yonzhan
|
FumingZhang
reviewed
Jan 21, 2025
Member
FumingZhang
left a comment
FumingZhang
left a comment
There was a problem hiding this comment.
lgtm
Queued live test to validate the change.
- test_aks_create_with_ingress_appgw_addon
- test_aks_byo_subnet_with_ingress_appgw_addon
- test_aks_byo_appgw_with_ingress_appgw_addon
FumingZhang
reviewed
Jan 21, 2025
src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py
Outdated
Show resolved
Hide resolved
src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py
Outdated
Show resolved
Hide resolved
Member
|
Requeued live test, test passed! |
Member
|
/azp run |
FumingZhang
approved these changes
Jan 21, 2025
|
Azure Pipelines successfully started running 2 pipeline(s). |
Member
|
CI failed on case |
Member
|
@akshaysngupta I guess you'll have to rebase from latest main branch to pick up the change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks create -a ingress-appgw
az aks enable-addons -a ingress-appgw
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.